On Thu, 6 May 2010 14:24:17 -0700 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > On Wed, 5 May 2010 14:21:49 +0300 > Phil Carmody <ext-phil.2.carmody@xxxxxxxxx> wrote: > > > From: Phil Carmody <ext-phil.2.carmody@xxxxxxxxx> > > > > Only an out of memory error will cause ret to be set. > > > > Acked-by: Kirill A. Shutemov <kirill@xxxxxxxxxxxxx> > > Signed-off-by: Phil Carmody <ext-phil.2.carmody@xxxxxxxxx> > > --- > > mm/memcontrol.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index 90e32b2..09af773 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -3464,7 +3464,7 @@ static int mem_cgroup_unregister_event(struct cgroup *cgrp, struct cftype *cft, > > int type = MEMFILE_TYPE(cft->private); > > u64 usage; > > int size = 0; > > - int i, j, ret; > > + int i, j, ret = 0; > > > > mutex_lock(&memcg->thresholds_lock); > > if (type == _MEM) > > afacit the return value of cftype.unregister_event() is always ignored > anyway. Perhaps it should be changed to void-returning, or fixed. > > Ah, it's now "TODO". But hmm...."unregister_event()" is called by workqueue. (for avoiding race?) I think unregister_event should be "void" and mem_cgroup_unregister_event() should be implemented as "never fail" function. I'll try by myself....but if someone knows this event notifier implementation well, please. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>