On Tue, May 04, 2010 at 02:35:50PM -0300, Marcelo Jimenez wrote: > Hi, > > On Tue, Apr 20, 2010 at 20:07, Russell King - ARM Linux > <linux@xxxxxxxxxxxxxxxx> wrote: > > > > Well, it'll be about this number on everything using sparsemem extreme: > > > > #define SECTIONS_PER_ROOT (PAGE_SIZE / sizeof (struct mem_section)) > > > > and with only 32 sections, this is going to give a NR_SECTION_ROOTS value > > of zero. I think the calculation of NR_SECTIONS_ROOTS is wrong. > > > > #define NR_SECTION_ROOTS (NR_MEM_SECTIONS / SECTIONS_PER_ROOT) > > > > Clearly if we have 1 mem section, we want to have one section root, so > > I think this division should round up any fractional part, thusly: > > > > #define NR_SECTION_ROOTS ((NR_MEM_SECTIONS + SECTIONS_PER_ROOT - 1) / SECTIONS_PER_ROOT) > > Seems correct to me, Is there any idea when this gets committed? What should be asked is whether it has been tested - if not, can we find someone who can test and validate the change? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>