On 2010-04-22, at 07:29, Dan Magenheimer wrote: > Cleancache [PATCH 6/7] (was Transcendent Memory): ext4 hook > > Filesystems must explicitly enable cleancache. For ext4, > all other cleancache hooks are in the VFS layer. > > Signed-off-by: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> Given the minimal changes being done to ext3/ext4, I don't have any objection to this. Being able to hook ext4 into SSDs for hierarchical caching is something that will become increasingly important for huge ext4 filesystems. Acked-by: Andreas Dilger <adilger@xxxxxxx> > Diffstat: > super.c | 2 ++ > 1 file changed, 2 insertions(+) > > --- linux-2.6.34-rc5/fs/ext4/super.c 2010-04-19 17:29:56.000000000 -0600 > +++ linux-2.6.34-rc5-cleancache/fs/ext4/super.c 2010-04-21 10:13:00.000000000 -0600 > @@ -39,6 +39,7 @@ > #include <linux/ctype.h> > #include <linux/log2.h> > #include <linux/crc16.h> > +#include <linux/cleancache.h> > #include <asm/uaccess.h> > > #include "ext4.h" > @@ -1784,6 +1785,7 @@ static int ext4_setup_super(struct super > EXT4_INODES_PER_GROUP(sb), > sbi->s_mount_opt); > > + sb->cleancache_poolid = cleancache_init_fs(PAGE_SIZE); > return res; > } Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href