On Wed, Apr 28, 2010 at 01:47:19PM -0400, Rik van Riel wrote: > static inline void anon_vma_unlock(struct vm_area_struct *vma) never mind as this is RFC, lock is clear enough > @@ -1762,7 +1760,8 @@ static int expand_downwards(struct vm_area_struct *vma, > if (error) > return error; > > - anon_vma_lock(vma); > + spin_lock(&mm->page_table_lock); > + anon_vma_lock(vma, &mm->page_table_lock); This will cause a lock inversion (page_table_lock can only be taken after the anon_vma lock). I don't immediately see why the page_table_lock here though? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>