On Tue, Apr 20, 2010 at 5:44 PM, Mel Gorman <mel@xxxxxxxxx> wrote: > On Tue, Apr 20, 2010 at 05:32:13PM +0900, Minchan Kim wrote: >> >> Yes. Then, Let's add comment like split_page. :) >> /* >> * Note: this is probably too low level an operation for use in drivers. >> * Please consult with lkml before using this in your driver. >> */ >> > > I can, but the comment that was there says it's like split_page except the > page is already free. This also covers not using it in a driver. I see. In addition, you already mentioned "As this is only being used for migration". I missed one. I don't have any against one. Will you repost v2 which move split_free_pages out of compaction.c? Anyway, feel free to add my reviewed-by sign. Thanks, Mel. Reviewed-by: Minchan Kim <minchan.kim@xxxxxxxxx> > > -- > Mel Gorman > Part-time Phd Student Linux Technology Center > University of Limerick IBM Dublin Software Lab > -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href