On Tue, 13 Apr 2010, Mel Gorman wrote: > This appears to be a valid bug fix. I agree that the way things are structured > that __GFP_THISNODE should be used in new_node_page(). But maybe a follow-on > patch is also required. The behaviour is now; What bug is being fixed? migrate_pages() is a best effort approach. __GFP_THISNODE is used when allocation on a specific node is absolutely required for correctness (as in SLAB). > If -ENOMEM is returned from migrate_pages, should it not move to the next node? Which it does now if you dont apply the "bugfix". -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>