On Wed, Apr 14, 2010 at 9:22 AM, KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote: > On Wed, 14 Apr 2010 00:25:02 +0900 > Minchan Kim <minchan.kim@xxxxxxxxx> wrote: > >> __vmalloc_area_node never pass -1 to alloc_pages_node. >> It means node's validity check is unnecessary. >> So we can use alloc_pages_exact_node instead of alloc_pages_node. >> It could avoid comparison and branch as 6484eb3e2a81807722 tried. >> >> Cc: Nick Piggin <npiggin@xxxxxxx> >> Signed-off-by: Minchan Kim <minchan.kim@xxxxxxxxx> > > Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > > But, in another thinking, > > - if (node < 0) > - page = alloc_page(gfp_mask); > > may be better ;) I thought it. but alloc_page is different function with alloc_pages_node in NUMA. It calls alloc_pages_current. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href