Hi Jonathan, On Wed, Mar 24, 2010 at 02:59:46PM -0600, Jonathan Corbet wrote: > On Wed, 24 Mar 2010 13:33:47 -0700 > Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > + VM_BUG_ON(cc == NULL); > > > > It's a bit strange to test this when we're about to oops anyway. The > > oops will tell us the same thing. > > ...except that we've seen a fair number of null pointer dereference > exploits that have told us something altogether different. Are we > *sure* we don't want to test for null pointers...? Examples? Maybe WARN_ON != oops, but VM_BUG_ON still an oops that is and without serial console it would go lost too. I personally don't see how it's needed. Plus those things are mostly for debug to check for invariant condition, how long it takes to sort it out isn't very relevant. So I'm on Andrew camp ;). -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>