On Wed, 24 Mar 2010 14:18:45 +0900 Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx> wrote: > On Fri, Mar 19, 2010 at 05:13:10PM +0900, KAMEZAWA Hiroyuki wrote: > ... > > > > > > But, this means hugeltb_entry() is not called per hugetlb entry...isn't it ? > > > > > > Why hugetlb_entry() cannot be called per hugeltb entry ? Don't we need a code > > > for a case as pmd_size != hugetlb_size in walk_page_range() for generic fix ? > > > > > > > How about this style ? This is an idea-level patch. not tested at all. > > (I have no test enviroment for multiple hugepage size.) > > > > feel free to reuse fragments from this patch. > > > > So the point is calling hugetlb_entry() for each huge page, right? > yes. > It looks good. > I've rewritten my patch based on your idea and make sure it works. > Is it ok to add your Signed-off-by? Of course. Thanks. -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>