On Tue, Mar 23, 2010 at 12:56:30PM -0500, Christoph Lameter wrote: > On Tue, 23 Mar 2010, Mel Gorman wrote: > > > diff --git a/include/linux/swap.h b/include/linux/swap.h > > index 1f59d93..cf8bba7 100644 > > --- a/include/linux/swap.h > > +++ b/include/linux/swap.h > > @@ -238,6 +239,11 @@ static inline void lru_cache_add_active_file(struct page *page) > > __lru_cache_add(page, LRU_ACTIVE_FILE); > > } > > > > +/* LRU Isolation modes. */ > > +#define ISOLATE_INACTIVE 0 /* Isolate inactive pages. */ > > +#define ISOLATE_ACTIVE 1 /* Isolate active pages. */ > > +#define ISOLATE_BOTH 2 /* Isolate both active and inactive pages. */ > > + > > /* linux/mm/vmscan.c */ > > extern unsigned long try_to_free_pages(struct zonelist *zonelist, int order, > > gfp_t gfp_mask, nodemask_t *mask); > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index 79c8098..ef89600 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -839,11 +839,6 @@ keep: > > return nr_reclaimed; > > } > > > > -/* LRU Isolation modes. */ > > -#define ISOLATE_INACTIVE 0 /* Isolate inactive pages. */ > > -#define ISOLATE_ACTIVE 1 /* Isolate active pages. */ > > -#define ISOLATE_BOTH 2 /* Isolate both active and inactive pages. */ > > - > > /* > > * Attempt to remove the specified page from its LRU. Only take this page > > * if it is of the appropriate PageActive status. Pages which are being > > Put the above in a separate patch? > I can if you prefer but it's so small, I didn't think it obscured the clarity of the patch anyway. I would have somewhat expected the two patches to be merged together before going upstream. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>