On Fri, Mar 19, 2010 at 04:15:04PM +0900, KAMEZAWA Hiroyuki wrote: > On Fri, 19 Mar 2010 15:53:34 +0900 > Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx> wrote: > > > On Fri, Mar 19, 2010 at 03:29:34PM +0900, KAMEZAWA Hiroyuki wrote: > > > On Fri, 19 Mar 2010 15:26:35 +0900 > > > Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx> wrote: > > > > > > > If !CONFIG_HUGETLB_PAGE, pagemap_hugetlb_range() is never called. > > > > So put it (and its calling function) into #ifdef block. > > > > > > > > Signed-off-by: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx> > > > > > > Hmm? What is benefit ? Is this broken now ? > > > > > > > Not broken, but this is needed to avoid build error with patch 2/2 applied, > > where I move huge_pte_offset() (not defined when !HUGETLB_PAGE) > > into pagemap_hugetlb_range(). > > > > I think this should be merged with 2/2....if necessary. > I split them for ease of review. Also removing unused code is beneficial as it reduces kernel binary size. But if you really want, I can merge them into one patch. Thanks, Naoya Horiguchi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>