On 03/17/2010 06:57 PM, Christoph Hellwig wrote:
On Wed, Mar 17, 2010 at 06:40:30PM +0200, Avi Kivity wrote:
Chris, can you carry out an experiment? Write a program that pwrite()s
a byte to a file at the same location repeatedly, with the file opened
using O_SYNC. Measure the write rate, and run blktrace on the host to
see what the disk (/dev/sda, not the volume) sees. Should be a (write,
flush, write, flush) per pwrite pattern or similar (for writing the data
and a journal block, perhaps even three writes will be needed).
Then scale this across multiple guests, measure and trace again. If
we're lucky, the flushes will be coalesced, if not, we need to work on it.
As the person who has written quite a bit of the current O_SYNC
implementation and also reviewed the rest of it I can tell you that
those flushes won't be coalesced. If we always rewrite the same block
we do the cache flush from the fsync method and there's is nothing
to coalesced it there. If you actually do modify metadata (e.g. by
using the new real O_SYNC instead of the old one that always was O_DSYNC
that I introduced in 2.6.33 but that isn't picked up by userspace yet)
you might hit a very limited transaction merging window in some
filesystems, but it's generally very small for a good reason. If it
were too large we'd make the once progress wait for I/O in another just
because we might expect transactions to coalesced later. There's been
some long discussion about that fsync transaction batching tuning
for ext3 a while ago.
I definitely don't expect flush merging for a single guest, but for
multiple guests there is certainly an opportunity for merging. Most
likely we don't take advantage of it and that's one of the problems.
Copying data into pagecache so that we can merge the flushes seems like
a very unsatisfactory implementation.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>