On Tue, 2010-03-16 at 14:50 +0900, KOSAKI Motohiro wrote: > Currently, following mount operation cause mount error. > > % mount -t tmpfs -ompol=bind:0 none /tmp > > Because commit 71fe804b6d5 (mempolicy: use struct mempolicy pointer in > shmem_sb_info) corrupted MPOL_BIND parse code. > > This patch restore the needed one. > > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> > Cc: Ravikiran Thirumalai <kiran@xxxxxxxxxxxx> > Cc: Christoph Lameter <cl@xxxxxxxxxxxxxxxxxxxx> > Cc: Mel Gorman <mel@xxxxxxxxx> > Cc: Lee Schermerhorn <lee.schermerhorn@xxxxxx> > Cc: Hugh Dickins <hugh.dickins@xxxxxxxxxxxxx> > Cc: <stable@xxxxxxxxxx> There's a trailing space in the patch, but except for that: Acked-by: Lee Schermerhorn <lee.schermerhorn@xxxxxx> > --- > mm/mempolicy.c | 10 +++++++--- > 1 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 25a0c0f..3f77062 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -2220,9 +2220,13 @@ int mpol_parse_str(char *str, struct mempolicy **mpol, int no_context) > if (!nodelist) > err = 0; > goto out; > - /* > - * case MPOL_BIND: mpol_new() enforces non-empty nodemask. > - */ > + case MPOL_BIND: > + /* trailing space ^ > + * Insist on a nodelist > + */ > + if (!nodelist) > + goto out; > + err = 0; > } > > mode_flags = 0; -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>