On Fri, 5 Feb 2010 10:16:02 +0900 Paul Mundt <lethal@xxxxxxxxxxxx> wrote: > On Fri, Feb 05, 2010 at 09:38:06AM +0900, Daisuke Nishimura wrote: > > On Thu, 4 Feb 2010 16:44:41 +0900, KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote: > > > On Thu, 4 Feb 2010 16:18:40 +0900 > > > Paul Mundt <lethal@xxxxxxxxxxxx> wrote: > > > > CONFIG_SWAP itself is configurable even with CONFIG_MMU=y, so having > > > > stubbed out helpers for the CONFIG_SWAP=n case would give the compiler a > > > > chance to optimize things away in those cases, too. Embedded systems > > > > especially will often have MMU=y and BLOCK=n, resulting in SWAP being > > > > unset but swap cache encodings still defined. > > > > > > > > How about just changing the is_swap_pte() definition to depend on SWAP > > > > instead? > > > > > > > I think the new feature as "move task charge" itself depends on CONFIG_MMU > > > because it walks a process's page table. > > > > > > Then, how about this ? (sorry, I can't test this in valid way..) > > > > > I agree to this direction of making "move charge" depend on CONFIG_MMU, > > although I can't test !CONFIG_MMU case either. > > > I'll try to give it a test on nommu today and see how it goes. The patch is still breaking the NOMMU build for me: mm/memcontrol.c: In function `is_target_pte_for_mc': mm/memcontrol.c:3641: error: implicit declaration of function `is_swap_pte' btw, sh allmodconfig gives me a huge spew related to the missing definition of pt_regs: /usr/src/25/arch/sh/include/asm/system.h:166: warning: parameter has incomplete type /usr/src/25/arch/sh/include/asm/system.h:167: warning: parameter has incomplete type /usr/src/25/arch/sh/include/asm/system.h:168: warning: parameter has incomplete type /usr/src/25/arch/sh/include/asm/system.h:169: warning: parameter has incomplete type /usr/src/25/arch/sh/include/asm/system.h:170: warning: parameter has incomplete type /usr/src/25/arch/sh/include/asm/system.h:171: warning: parameter has incomplete type /usr/src/25/arch/sh/include/asm/system.h:172: warning: parameter has incomplete type /usr/src/25/arch/sh/include/asm/system.h:173: warning: parameter has incomplete type The `struct pt_regs;' declararion isn't enough - it wants to see the definition. I think. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>