On Thu, 4 Mar 2010, Lee Schermerhorn wrote: > Well, in linux/percpu-defs.h after the first patch in this series, but > x86 is overriding it with the percpu_to_op() implementation. You're > saying that the x86 percpu_to_op() macro doesn't handle 8-byte 'pcp' > operands? It appears to handle sizes 1, 2, 4 and 8. 8 byte operands are not allowed for 32 bit but work on 64 bit. > So, I'll remove those definitions in V4. Ok. > Do we want to retain the x86 definitions of __this_cpu_xxx_[124]() or > remove those and let the generic definitions handle them? Generic definitions would not be as efficient as the use of the segment register to shift the address to the cpu area. I have not figured out exactly what you are doing with the percpu definitions and why yet. Ill look at that when I have some time. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>