On Wed, 3 Mar 2010 15:27:53 -0800 (PST) David Rientjes <rientjes@xxxxxxxxxx> wrote: > On Wed, 3 Mar 2010, KAMEZAWA Hiroyuki wrote: > > > In patch 01-03, you don't modified panic_on_oom implementation. > > And this patch, you don't modified the return code of memcg's charge code. > > It still returns -ENOMEM. > > > > Then, VM_FAULT_OOM is returned and page_fault_out_of_memory() calles this > > and hit this. > > > > case CONSTRAINT_NONE: > > if (sysctl_panic_on_oom) { > > dump_header(NULL, gfp_mask, order, NULL); > > panic("out of memory. panic_on_oom is selected\n"); > > } > > > > The system will panic. A hook, mem_cgroup_oom_called() is for avoiding this. > > memcg's oom doesn't mean memory shortage, just means it his limit. > > > > And this is fixed by memcg-fix-oom-kill-behavior-v3.patch in -mm, right? > yes. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>