On Thu, 25 Feb 2010, Dmitry Monakhov wrote: > @@ -1020,6 +1021,11 @@ static int __init setup_slub_debug(char *str) > case 't': > slub_debug |= SLAB_TRACE; > break; > +#ifdef CONFIG_FAILSLAB > + case 'a': > + slub_debug |= SLAB_FAILSLAB; > + break; > +#endif > default: > printk(KERN_ERR "slub_debug option '%c' " > "unknown. skipped\n", *str); The #ifdef is unnecessary, SLAB_FAILSLAB is 0x0 when CONFIG_FAILSLAB isn't set. When that's changed, feel free to add my: Acked-by: David Rientjes <rientjes@xxxxxxxxxx> and send an updated version to Pekka Enberg <penberg@xxxxxxxxxxxxxx> and cc Christoph Lameter <cl@xxxxxxxxxxxxxxxxxxxx>. I guess 'A' is the best letter to use for `slub_debug' (fAil slab? :) since 'F' is already used. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>