Hi, On Wed, Feb 24, 2010 at 12:03:13AM +0900, Minchan Kim wrote: > On Mon, 2010-02-22 at 20:49 +0100, Johannes Weiner wrote: > > diff --git a/mm/rmap.c b/mm/rmap.c > > index 278cd27..5a48bda 100644 > > --- a/mm/rmap.c > > +++ b/mm/rmap.c > > @@ -511,9 +511,6 @@ int page_referenced(struct page *page, > > int referenced = 0; > > int we_locked = 0; > > > > - if (TestClearPageReferenced(page)) > > - referenced++; > > - > > >From now on, page_referenced see only page table for reference. > So let's comment it on function description. > like "This function checks reference from only pte" Hehe, the function comment already says: * returns the number of ptes which referenced the page. so it is already correct. Only the code did not match it until now. > It looks good to me except PAGEREF_RECLAIM_CLEAN. > > I am glad to meet your this effort, again, Hannes. :) Thank you for your review, Hannes -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>