On Fri, Feb 19, 2010 at 07:16:13PM -0500, Rik van Riel wrote: > On 02/19/2010 04:58 PM, Mel Gorman wrote: > >> external_refcount is about as good as I can think of to explain what's >> going on :/ > > Sounds "good" to me. Much better than giving the wrong > impression that this is the only refcount for the anon_vma. > Have renamed it so. If/when this all gets merged, I'll look into what's required to make this a "real" refcount rather than the existing locking mechanism. I'm very wary though because even with your anon_vma changes to avoid excessive sharing, a refcount in there that is used in all paths might become a hotly contended cache line. i.e. it might look nice, but it might be a performance hit. It needs to be done carefully and as a separate series. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>