On Tue, 16 Feb 2010, KAMEZAWA Hiroyuki wrote: > > As I already explained when you first brought this up, the possibility of > > not invoking the oom killer is not unique to GFP_DMA, it is also possible > > for GFP_NOFS. Since __GFP_NOFAIL is deprecated and there are no current > > users of GFP_DMA | __GFP_NOFAIL, that warning is completely unnecessary. > > We're not adding any additional __GFP_NOFAIL allocations. > > > > Please add documentation about that to gfp.h before doing this. > Doing this without writing any documenation is laziness. > (WARNING is a style of documentation.) > This is already documented in the page allocator, but I guess doing it in include/linux/gfp.h as well doesn't hurt. mm: add comment about deprecation of __GFP_NOFAIL __GFP_NOFAIL was deprecated in dab48dab, so add a comment that no new users should be added. Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx> --- include/linux/gfp.h | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/include/linux/gfp.h b/include/linux/gfp.h --- a/include/linux/gfp.h +++ b/include/linux/gfp.h @@ -30,7 +30,8 @@ struct vm_area_struct; * _might_ fail. This depends upon the particular VM implementation. * * __GFP_NOFAIL: The VM implementation _must_ retry infinitely: the caller - * cannot handle allocation failures. + * cannot handle allocation failures. This modifier is deprecated and no new + * users should be added. * * __GFP_NORETRY: The VM implementation must not retry indefinitely. * -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>