Thank you for review. This is v2. Thanks, -Kame On Fri, 12 Feb 2010 15:44:22 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote: > These 2 patches are updates for memcg's event counter. > > Memcg has 2 counters but they counts the same thing. Just usages are > different from each other. This patch tries to combine them. > > Event counting is done per page but event check is done per charge. > But, now, move_task at el. does charge() in batched manner. So, it's better > to do event check per page (not per charge.) > > (*) There may be an opinion that threshold check should be done at charge(). > But, at charge(), event counter is not incremented, anyway. > Then, some another idea is appreciated to check thresholds at charges. > In other view, checking threshold at "precharge" can cause miss-fire of > event notifier. So, checking threshold at commit has some sense, I think. > > I wonder I should add RFC..but this patch clears my concerns since memcg-threshold > was merged. So, I didn't. > > Any comment is welcome. (I'm sorry if my reply is delayed.) > > Thanks, > -Kame > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>