On Thu, 11 Feb 2010, Andi Kleen wrote: > When fallback_alloc() runs the node of the CPU might not be initialized yet. > Handle this case by allocating in another node. > > v2: Try to allocate from all nodes (David Rientjes) > You don't need to specifically address the cpuset restriction in fallback_alloc() since kmem_getpages() will return NULL whenever a zone is tried from an unallowed node, I just thought it was a faster optimization considering you (i) would operate over a nodemask and not the entire zonelist, (ii) it would avoid the zone_to_nid() for all zones since you already did a zonelist iteration in this function, and (iii) it wouldn't needlessly call kmem_getpages() for unallowed nodes. > Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx> That said, I don't want to see this fix go unmerged since you already declined to make that optimization once: Acked-by: David Rientjes <rientjes@xxxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>