On Sat, 6 Feb 2010, Andi Kleen wrote: > > in the series; slab_node_prepare() is called in that previous patch by a > > memory hotplug callback without holding cache_chain_mutex (it's taken by > > the cpu hotplug callback prior to calling cpuup_prepare() currently). So > > slab_node_prepare() should note that we require the mutex and the memory > > hotplug callback should take it in the previous patch. > > AFAIK the code is correct. If you feel the need for additional > documentation feel free to send patches yourself. > Documentation? You're required to take cache_chain_mutex before calling slab_node_prepare() in your memory hotplug notifier, it iterates cache_chain. Please look again. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>