On Tue, 18 Feb 2025, WangYuli wrote:
> Currently, dec_irq_dispatch() is exclusively invoked by int-handler.S.
It always has been, since its inception, see commit 187933f23679 ("[MIPS]
do_IRQ cleanup").
> Inline the do_IRQ call into int-handler.S to silence the compiler
> warning.
Up to commit 8f99a16265353 ("MIPS: Tracing: Add IRQENTRY_EXIT section for
MIPS") `do_IRQ' used to be a macro, that's why. At the time `do_IRQ' was
converted to a macro `dec_irq_dispatch' was created and previously this
place used to call `do_IRQ' too.
It's always good finding out why things are as they are so as to make
sure you haven't been missing something. This cleanup should have been
made along with commit 8f99a16265353, so it's pretty old a technical debt
being sorted here.
Please add these findings to your commit description in v2.
NB I'm off on holiday starting from tomorrow and I had issues with DEC
hardware in my lab (now sorted, required a visit on site) so I couldn't
get to your stuff sooner and also I won't be able to verify any of this
until I'm back mid-March.
Maciej
