On Wed, 12 Feb 2025, WangYuli wrote:
> There are expression and spelling errors in my commit message and code
> comments, necessitating a patch v2 for corrections, is that right?
These are semantic errors, yes.
Also I find:
Fixes: 805b2e1d427a ("kbuild: include Makefile.compiler only when compiler is needed")
invalid here, as your change does not address an issue introduced with
said commit. It does fix mine, when it comes to LLVM support, so I think
instead it has to be:
Fixes: a79a404e6c22 ("MIPS: Fix CONFIG_CPU_DADDI_WORKAROUNDS `modules_install' regression")
And if you want it backported, then you need to swap the order of the
changes or discard 1/2 altogether, as that is syntactic noise only and
clearly not a fix.
Apologies not to point these issues out in the previous message.
> As for whether to check need-compiler or KBUILD_SYM32 in the code, the effect
> is essentially the same, correct?
No, code has to express intent and the intent here is not to fiddle with
the compilation flags when no compiler is going to be used. And this
purpose is served by the `need-compiler' setting; anything else is code
obfuscation and a workaround at best. And the very need to add a comment
has made it very obvious already: the best code is self-explanatory and
the use of `need-compiler' is a common idiom, obviating the need for a
comment here.
Have I made myself clear here?
Maciej
