On Tue, 14 Jan 2025, Arnd Bergmann wrote: > >> A quick fix would be #undef PCI_IOBASE in arch/mips/include/asm/io.h > >> just after including #include <asm-generic/io.h>, with ralink and loongson64 > >> as exception. > > > > Shouldn't arch/mips/include/asm/io.h do > > > > #define PCI_IOBASE mips_io_port_base > > > > unconditionally, _before_ including <asm-generic/io.h>? > > Yes, I think this would make the most sense, but the ordering > with the PCI initialization needs to be done carefully, > to ensure that PCI_IOBASE has its final value before the first > call to pci_remap_iospace(). Is defining PCI_IOBASE going to do the right thing for non-PCI MIPS platforms, or should the definition be #ifdef CONFIG_PCI rather than unconditional? FWIW I think all PCI MIPS platforms support port I/O. Maciej
