On Thu, Dec 12, 2024 at 03:45:16PM +0000, Matthew Wilcox wrote: > On Thu, Dec 12, 2024 at 03:36:47PM +0000, Lorenzo Stoakes wrote: > > +++ b/mm/vma.h > > @@ -242,9 +242,9 @@ bool vma_wants_writenotify(struct vm_area_struct *vma, pgprot_t vm_page_prot); > > int mm_take_all_locks(struct mm_struct *mm); > > void mm_drop_all_locks(struct mm_struct *mm); > > > > -unsigned long __mmap_region(struct file *file, unsigned long addr, > > - unsigned long len, vm_flags_t vm_flags, unsigned long pgoff, > > - struct list_head *uf); > > +unsigned long mmap_region(struct file *file, unsigned long addr, > > + unsigned long len, vm_flags_t vm_flags, unsigned long pgoff, > > + struct list_head *uf); > > Please don't line up the arguments with the paren. Just leave it as two > tabs. > Ack, emacs likes to do this, will tweak on respin assuming mips guys confirm that idea works!
