Re: [PATCH v6 8/8] x86/module: enable ROX caches for module text on 64 bit

Date Prev

Date Next

Thread Prev

Thread Next

Date Index

Thread Index

To: Mike Rapoport <rppt@xxxxxxxxxx>

Subject: Re: [PATCH v6 8/8] x86/module: enable ROX caches for module text on 64 bit

From: Luis Chamberlain <mcgrof@xxxxxxxxxx>

Date: Sat, 19 Oct 2024 15:46:33 -0700

Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Andreas Larsson <andreas@xxxxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, Ard Biesheuvel <ardb@xxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Brian Cain <bcain@xxxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Dinh Nguyen <dinguyen@xxxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Guo Ren <guoren@xxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Huacai Chen <chenhuacai@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>, Kent Overstreet <kent.overstreet@xxxxxxxxx>, "Liam R. Howlett" <Liam.Howlett@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Matt Turner <mattst88@xxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Michal Simek <monstr@xxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Stafford Horne <shorne@xxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Suren Baghdasaryan <surenb@xxxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Uladzislau Rezki <urezki@xxxxxxxxx>, Vineet Gupta <vgupta@xxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, bpf@xxxxxxxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-csky@xxxxxxxxxxxxxxx, linux-hexagon@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-modules@xxxxxxxxxxxxxxx, linux-openrisc@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, linux-snps-arc@xxxxxxxxxxxxxxxxxxx, linux-trace-kernel@xxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, loongarch@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx

In-reply-to: <20241016122424.1655560-9-rppt@kernel.org>

References: <20241016122424.1655560-1-rppt@kernel.org> <20241016122424.1655560-9-rppt@kernel.org>

On Wed, Oct 16, 2024 at 03:24:24PM +0300, Mike Rapoport wrote:
> From: "Mike Rapoport (Microsoft)" <rppt@xxxxxxxxxx>
> 
> Enable execmem's cache of PMD_SIZE'ed pages mapped as ROX for module
> text allocations on 64 bit.
> 
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>

Reviewed-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>

  Luis