On Wed, Sep 25, 2024 at 09:19:17AM GMT, Shakeel Butt wrote: > I have no idea what makes you think I am blocking the feature that you > repond in a weird tone but let me be upfront what I am asking: Let's > collectively decide which is the better option (in terms of > maintainability and extensibility) and move forward. I'm not sure what you mean by 'weird tone'... perhaps a miscommunication? To summarise in my view - a suggestion was made to, rather than provide the proposed flag - a pidfd sentinel should be introduced. Simply introducing a sentinel that represents 'the current process' without changing interfaces that accept a pidfd would be broken - so implementing this implies that _all_ pidfd interfaces are updated, as well as tests. I suggest doing so is, of course, entirely out of the scope of this change. Therefore if we were to require that here - it would block the feature while I go work on that. I think this is pretty clear right? And I also suggest that doing so is likely to take quite some time, and may not even have a positive outcome. So it's not a case of 'shall we take approach A or approach B?' but rather 'should we take approach A or entirely implement a new feature B, then once that is done, use it'. So as to your 'collectively decide what is the better option' - in my previous response I argued that the best approach between 'use an unimplemented suggested entirely new feature of pidfd' vs. 'implement a flag that would in no way block the prior approach' - a flag works better. If you can provide specific arguments as to why I'm wrong then by all means I'm happy to hear them. > > On Wed, Sep 25, 2024 at 03:48:07PM GMT, Lorenzo Stoakes wrote: > > On Wed, Sep 25, 2024 at 07:02:59AM GMT, Shakeel Butt wrote: > > > Cced Christian > > > > > > On Tue, Sep 24, 2024 at 02:12:49PM GMT, Lorenzo Stoakes wrote: > > > > On Tue, Sep 24, 2024 at 01:51:11PM GMT, Pedro Falcato wrote: > > > > > On Tue, Sep 24, 2024 at 12:16:27PM GMT, Lorenzo Stoakes wrote: > > > > > > process_madvise() was conceived as a useful means for performing a vector > > > > > > of madvise() operations on a remote process's address space. > > > > > > > > > > > > However it's useful to be able to do so on the current process also. It is > > > > > > currently rather clunky to do this (requiring a pidfd to be opened for the > > > > > > current process) and introduces unnecessary overhead in incrementing > > > > > > reference counts for the task and mm. > > > > > > > > > > > > Avoid all of this by providing a PR_MADV_SELF flag, which causes > > > > > > process_madvise() to simply ignore the pidfd parameter and instead apply > > > > > > the operation to the current process. > > > > > > > > > > > > > > > > How about simply defining a pseudo-fd PIDFD_SELF in the negative int space? > > > > > There's precedent for it in the fs space (AT_FDCWD). I think it's more ergonomic > > > > > and if you take out the errno space we have around 2^31 - 4096 available sentinel > > > > > values. > > > > > > > > > > e.g: > > > > > > > > > > /* AT_FDCWD = -10, -1 is dangerous, pick a different value */ > > > > > #define PIDFD_SELF -11 > > > > > > > > > > int pidfd = target_pid == getpid() ? PIDFD_SELF : pidfd_open(...); > > > > > process_madvise(pidfd, ...); > > > > > > > > > > > > > > > What do you think? > > > > > > > > I like the way you're thinking, but I don't think this is something we can > > > > do in the context of this series. > > > > > > > > I mean, I totally accept using a flag here and ignoring the pidfd field is > > > > _ugly_, no question. But I'm trying to find the smallest change that > > > > achieves what we want. > > > > > > I don't think "smallest change" should be the target. We are changing > > > user API and we should aim to make it as robust as possible against > > > possible misuse or making uninteded assumptions. > > > > I think introducing a new pidfd sentinel that isn't used anywhere else is > > far more liable to mistakes than adding an explicit flag. > > > > Could you provide examples of possible misuse of this flag or unintended > > assumptions it confers (other than the -1 thing addressed below). > > > > The flag is explicitly 'target this process, ignore pidfd'. We can document > > it as such (I will patch manpages too). > > > > > > > > The proposed implementation opened the door for the applications to > > > provide dummy pidfd if PR_MADV_SELF is used. You definitely need to > > > restrict it to some known value like -1 used by mmap() syscall. > > > > Why? > > > > mmap() is special in that you have a 'dual' situation with shmem that is > > both file-backed and private and of course you can do MAP_SHARED | > > MAP_PRIVATE and have mmap() transparently assign something to you, etc. > > > > Here we explicitly have a flag whose semantics are 'ignore pidfd, target > > self'. > > > > If you choose to use a brand new flag that explicitly states this and > > provide a 'dummy' pidfd which then has nothing done to it - what exactly is > > the problem? > > IMHO having a fixed dummy would allow the kernel more flexibility in > future for evolving the API. OK. I agree with having a fixed dummy value as stated. > > > > > I mean if you feel strongly, we can enforce this, but I'm not sure -1 > > implying a special case for pidfd is a thing either. > > > > On the other hand it would be _weird_ and broken for the user to provide a > > valid pidfd so maybe we should as it is easy to do and the user has clearly > > done something wrong. > > > > So fine, agreed, I'll add that. > > > > No, don't just agree. The response like "-1 is not good for so and so > reasons" is totally fine and my request would be add that reasoning in > the commit message. My only request is that we have thought through > alternatives and document the reasonsing behind the decided approach. I didn't just agree, as I said, my reasoning is: On the other hand it would be _weird_ and broken for the user to provide a valid pidfd so maybe we should as it is easy to do and the user has clearly done something wrong. If we're in alignment with that then all good! > > > > > > > > > > > > To add such a sentinel would be a change to the pidfd mechanism as a whole, > > > > and we'd be left in the awkward situation that no other user of the pidfd > > > > mechanism would be implementing this, but we'd have to expose this as a > > > > general sentinel value for all pidfd users. > > > > > > There might be future users which can take advantage of this. I can even > > > imagine pidfd_send_signal() can use PIDFD_SELF as well. > > > > I'm confused by this comment - I mean absolutely, as I said I like the > > idea, but this just proves the point that you'd have to go around and > > implement this everywhere that uses a pidfd? > > > > That is a big undertaking, and not blocked by this change. Nor is > > maintaining the flag proposed here egregious. > > By big undertaking, do you mean other syscalls that take pidfd > (pidfd_getfd, pidfd_send_signal & process_mrelease) to handle PIDFD_SELF > or something else? I mean if you add a pidfd sentinel that represents 'the current process' it may get passed to any interface that accepts a pidfd, so all of them have to handle it _somehow_. Also you'll want to update tests accordingly and clearly need to get community buy-in for that feature. You may want to just add a bunch of: if (pidfd == SENTINEL) return -EINVAL; So it's not impossible my instincts are off and we can get away with simply doing that. On the other hand, would that be confusing? Wouldn't we need to update documentation, manpages, etc. to say explicitly 'hey this sentinel is just not supported'? Again totally fine with the idea, like it actually, just my instincts are it will involve some work. I may be wrong. > > > > > Blocking a useful feature because we may in future possibly add a new means > > of doing the same thing seems a little silly to me. > > > > Hah!! See top of mail. > > > > > > > > > One nice thing with doing this as a flag is that, later, if somebody is > > > > willing to do the larger task of having a special sentinel pidfd value to > > > > mean 'the current process', we could use this in process_madvise() and > > > > deprecate this flag :) > > > > > > > > > > Once something is added to an API, particularly syscalls, the removal > > > is almost impossible. > > > > And why would it be such a problem to have this flag remain? I said > > deprecate not remove. And only in the sense that 'you may as well use the > > sentinel'. > > > > My point was to aim for the solution where we can avoid such scenario > but it is totally understandable and acceptable that we still have to go > through deprecation process in future. > > > The flag is very clear in its meaning, and confers no special problem in > > remaining supported. It is a private flag that overlaps no others. > > > > I mean it'd in effect being a change to a single line 'if pidfd is sentinel > > or flag is used'. If we can't support that going forward, then we should > > give up this kernel stuff and frolick in the fields joyously instead... > > > > Again, if you can tell me why it'd be such a problem then fine we can > > address that. > > > > But blocking a series and demanding a change to an entire other feature > > just to support something I'd say requires some pretty specific reasons as > > to why you have a problem with the change. > > > > > > > > Anyways, I don't have very strong opinion one way or other but whatever > > > we decide, let's make it robust. > > > > I mean... err... it sounds like you do kinda have pretty strong opinions ;) > > I am not sure how more explicit I have to be to but I am hoping now it > is more clear than before. I mean perhaps I misinterpreted you as strongly advocating for the sentinel and your intent was rather to provide argument on that side also so the community can decide as you say - sure. But with you indifferent as you say as to which way to go, and my having provided arguments for the flags (again happy to hear push-back of course) - I suggest we go forward with the series as-is, other than a fixpatch I'll send for the -1 thing. > > Shakeel Thanks for your review!
