Hi Rong, On Mon, Sep 09, 2024 at 04:58:10PM GMT, Rong Qianfeng wrote: > > I'm not a big fan of this change. There is not much gain in > > polluting git bisect in order to shorten pdev->dev to a single > > dev. > > > > However, I like the /dev_err/dev_err_probe/. > > > > I will take the first two patches from this series, but I will > > leave this if anyone else has a stronger opinion. If you want, > > you can send just this one patch with just the dev_err_probe() > > change. > Thanks for taking the time to review my patch! > Please take the first two patches, I don't plan to submit another > patch that only modifies dev_err(). Sorry, I forgot to write it, I merged the first two in i2c/i2c-host. If you want to send one to change dev_err with dev_err_probe separately I will take it. Thanks, Andi