On Wed, 2024-09-04 at 03:06 +0100, Maciej W. Rozycki wrote:
> -#include <linux/types.h>
> -
> /*
> * Keep this struct definition in sync with the sigcontext fragment
> * in arch/mips/tools/offset.c
> @@ -66,6 +64,9 @@ struct sigcontext {
> };
>
> #ifdef __KERNEL__
> +
> +#include <linux/posix_types.h>
> +
> struct sigcontext32 {
> __u32 sc_regmask; /* Unused */
> __u32 sc_status;
>
> so not without explanation and clearly to address a userland compilation
> issue. It seems that the original directive should have just been moved
> into the __KERNEL__ part without changing the file included though.
Yes, I just mean *changing* the include file is not explained and it
seems an error. I'm not familiar with ancient kernels but AFAIK for
using __u32 etc. we should use linux/types.h since Linux 1.2.
Moving the include into #ifdef __KERNEL__ makes sense to me.
--
Xi Ruoyao <xry111@xxxxxxxxxxx>
School of Aerospace Science and Technology, Xidian University
