Re: [PATCH net-next v23 06/13] memory-provider: dmabuf devmem memory provider

Date Prev

Date Next

Thread Prev

Thread Next

Date Index

Thread Index

To: Mina Almasry <almasrymina@xxxxxxxxxx>

Subject: Re: [PATCH net-next v23 06/13] memory-provider: dmabuf devmem memory provider

From: Jakub Kicinski <kuba@xxxxxxxxxx>

Date: Thu, 29 Aug 2024 14:28:39 -0700

Cc: netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-trace-kernel@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Donald Hunter <donald.hunter@xxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>, Matt Turner <mattst88@xxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Andreas Larsson <andreas@xxxxxxxxxxx>, Jesper Dangaard Brouer <hawk@xxxxxxxxxx>, Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Steffen Klassert <steffen.klassert@xxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, David Ahern <dsahern@xxxxxxxxxx>, Willem de Bruijn <willemdebruijn.kernel@xxxxxxxxx>, "Björn Töpel" <bjorn@xxxxxxxxxx>, Magnus Karlsson <magnus.karlsson@xxxxxxxxx>, Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx>, Jonathan Lemon <jonathan.lemon@xxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, Sumit Semwal <sumit.semwal@xxxxxxxxxx>, "Christian König" <christian.koenig@xxxxxxx>, Pavel Begunkov <asml.silence@xxxxxxxxx>, David Wei <dw@xxxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Yunsheng Lin <linyunsheng@xxxxxxxxxx>, Shailend Chand <shailend@xxxxxxxxxx>, Harshitha Ramamurthy <hramamurthy@xxxxxxxxxx>, Shakeel Butt <shakeel.butt@xxxxxxxxx>, Jeroen de Borst <jeroendb@xxxxxxxxxx>, Praveen Kaligineedi <pkaligineedi@xxxxxxxxxx>, Bagas Sanjaya <bagasdotme@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Nikolay Aleksandrov <razor@xxxxxxxxxxxxx>, Taehee Yoo <ap420073@xxxxxxxxx>, Willem de Bruijn <willemb@xxxxxxxxxx>, Kaiyuan Zhang <kaiyuanz@xxxxxxxxxx>

In-reply-to: <20240829060126.2792671-7-almasrymina@google.com>

References: <20240829060126.2792671-1-almasrymina@google.com> <20240829060126.2792671-7-almasrymina@google.com>

On Thu, 29 Aug 2024 06:01:19 +0000 Mina Almasry wrote:
> +	if (WARN_ON_ONCE(atomic_long_read(netmem_get_pp_ref_count_ref(netmem)) !=
> +		     1))

nit: temporary variable for this refcount, please