On Thu, Aug 22, 2024 at 11:39:12AM +0800, Lei Liu wrote: > The devm_clk_get_enabled() helpers: > - call devm_clk_get() > - call clk_prepare_enable() and register what is needed in order to > call clk_disable_unprepare() when needed, as a managed resource. > > This simplifies the code and avoids calls to clk_disable_unprepare(). ... > err_clk: > - clk_disable_unprepare(stm32port->clk); > > return ret; No unneeded label, please drop it as well and return directly. -- With Best Regards, Andy Shevchenko