Re: [PATCH net-next v15 08/14] net: support non paged skb frags

Date Prev

Date Next

Thread Prev

Thread Next

Date Index

Thread Index

To: Mina Almasry <almasrymina@xxxxxxxxxx>

Subject: Re: [PATCH net-next v15 08/14] net: support non paged skb frags

From: Eric Dumazet <edumazet@xxxxxxxxxx>

Date: Tue, 2 Jul 2024 15:14:22 +0200

Cc: netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-trace-kernel@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Donald Hunter <donald.hunter@xxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>, Matt Turner <mattst88@xxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Andreas Larsson <andreas@xxxxxxxxxxx>, Jesper Dangaard Brouer <hawk@xxxxxxxxxx>, Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Andrii Nakryiko <andrii@xxxxxxxxxx>, Martin KaFai Lau <martin.lau@xxxxxxxxx>, Eduard Zingerman <eddyz87@xxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Yonghong Song <yonghong.song@xxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, KP Singh <kpsingh@xxxxxxxxxx>, Stanislav Fomichev <sdf@xxxxxxxxxxx>, Hao Luo <haoluo@xxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Steffen Klassert <steffen.klassert@xxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, David Ahern <dsahern@xxxxxxxxxx>, Willem de Bruijn <willemdebruijn.kernel@xxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, Sumit Semwal <sumit.semwal@xxxxxxxxxx>, Christian König <christian.koenig@xxxxxxx>, Bagas Sanjaya <bagasdotme@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Nikolay Aleksandrov <razor@xxxxxxxxxxxxx>, Pavel Begunkov <asml.silence@xxxxxxxxx>, David Wei <dw@xxxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Yunsheng Lin <linyunsheng@xxxxxxxxxx>, Shailend Chand <shailend@xxxxxxxxxx>, Harshitha Ramamurthy <hramamurthy@xxxxxxxxxx>, Shakeel Butt <shakeel.butt@xxxxxxxxx>, Jeroen de Borst <jeroendb@xxxxxxxxxx>, Praveen Kaligineedi <pkaligineedi@xxxxxxxxxx>

In-reply-to: <20240628003253.1694510-9-almasrymina@google.com>

References: <20240628003253.1694510-1-almasrymina@google.com> <20240628003253.1694510-9-almasrymina@google.com>

On Fri, Jun 28, 2024 at 2:33 AM Mina Almasry <almasrymina@xxxxxxxxxx> wrote:
>
> Make skb_frag_page() fail in the case where the frag is not backed
> by a page, and fix its relevant callers to handle this case.
>
> Signed-off-by: Mina Almasry <almasrymina@xxxxxxxxxx>
>

Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>