Re: [PATCH v4 05/14] irqchip: mips-gic: Setup defaults in each cluster

[Thomas Gleixner <tglx@xxxxxxxxxxxxx>]

On Sat, May 11 2024 at 12:43, Aleksandar Rikalo wrote:
> From: Chao-ying Fu <cfu@xxxxxxxxxxxx>
>
> In multi-cluster MIPS I6500 systems we have a GIC per cluster. The
> default shared interrupt setup that we configure in gic_of_init() will
> only apply to the GIC in the cluster containing the boot CPU, leaving
> the GICs of other clusters unconfigured. Similarly configure other
> clusters here.

We ...

> +	nclusters = mips_cps_numclusters();
> +	for (cl = 0; cl < nclusters; cl++) {
> +		if (cl == cpu_cluster(&current_cpu_data)) {
> +			for (i = 0; i < gic_shared_intrs; i++) {
> +				change_gic_pol(i, GIC_POL_ACTIVE_HIGH);
> +				change_gic_trig(i, GIC_TRIG_LEVEL);
> +				write_gic_rmask(i);
> +			}
> +		} else {
> +			mips_cm_lock_other(cl, 0, 0,
> +					   CM_GCR_Cx_OTHER_BLOCK_GLOBAL);

Please get rid of these line breaks. You have 100 characters available.