Re: [PATCH v3 7/8] dt-bindings: mfd: Add img,boston-platform-regs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




在2024年6月20日六月 上午7:40,Krzysztof Kozlowski写道:
> On 19/06/2024 13:20, Jiaxun Yang wrote:
>> 
>> 
>> 在2024年6月19日六月 上午10:28,Krzysztof Kozlowski写道:
[...]
> Your children depend on parent to provide IO address, so this is not
> simple-mfd. Rule for simple-mfd is that children do not rely on parent
> at all.

I don't really get this.

As per syscon-rebbot.yaml:

The SYSCON registers map is normally retrieved from the
  parental dt-node. So the SYSCON reboot node should be represented as a
  sub-node of a "syscon", "simple-mfd" node.

syscon-reboot is certainly using parent node to provide I/O address,
even regmap property is deprecated. Without "simple-mfd", reboot node
won't be populated at all.

I'll remove the dependency of clock controller to parent node anyway.

Thanks
- Jiaxun

>
>> 
>> Linux managed to work without "simple-mfd" only because clock subsystem
>> is bypassing regular OF population process. Semantically we need this.
>
> Semantically? No, you need proper populate, not incorrect simple-mfd.
>
>> 
>> Besides Linux as upstream of devicetree source had accepted U-Boot
>> only stuff here, such as "bootph-all" property.
>
> Because bootph-all is valid and correct. Calling simple-mfd something
> which is not entirely simple-mfd is not that valid.
>
>
> Best regards,
> Krzysztof

-- 
- Jiaxun





[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux