Re: [PATCH v2] clocksource: Add node counter timer driver for MIPS/Loongson64

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




在2024年5月27日五月 下午4:51,Thomas Gleixner写道:
> Jiaxun!
>
Hi Thomas,
[...]
>
> What's this indirection for? Why dont you update 
[...]
>
>> +static struct clocksource nodecnt_clocksource = {
>> +	.name	= "nodecnt",
>> +	.read	= nodecnt_clocksource_read,
>
> the read function pointer here and spare the indirection?
Smart! sched_clock takes slightly different function pointer argument type
but as we don't use the argument anyway, it should be safe to relax this
indirection.

Will fix in v3.

Thanks
>
> Thanks
>
>         tglx

-- 
- Jiaxun





[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux