在2024年5月17日五月 上午9:58，Krzysztof Kozlowski写道： > On 15/05/2024 23:44, Jiaxun Yang wrote: >> >> >> 在2024年5月14日五月 上午10:11，Krzysztof Kozlowski写道： >>> On 14/05/2024 11:08, Krzysztof Kozlowski wrote: >>>> On 13/05/2024 20:58, Jiaxun Yang wrote: >>>>> This compatible has been used in arch/mips/boot/dts/img/boston.dts >>>>> for a while but never documented properly. >>>>> >>>>> Add it to simple syscon binding. >>>>> >>>>> Signed-off-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> >>>>> --- >>>>> Documentation/devicetree/bindings/mfd/syscon.yaml | 1 + >>>> >>>> It is documented in clock/img,boston-clock.txt. Please fix/convert/work >>>> on that. >>> >>> No, that's different device. >>> >>> Anyway, this is wrong - does no work with your second patch. Please test >>> them before sending. >> >> Hi Krzysztof, >> >> Do you mind telling dumb as me how to test bindings properly? >> >> I tried to run make check_dtbs after applying this patch and that's all >> the warnings I got: >> ``` >> arch/mips/boot/dts/img/boston.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider' >> /home/flygoat/linux-next/arch/mips/boot/dts/img/boston.dtb: /: 'model' is a required property >> from schema $id: http://devicetree.org/schemas/root-node.yaml# >> arch/mips/boot/dts/img/boston.dtb: /: failed to match any schema with compatible: ['img,boston'] >> arch/mips/boot/dts/img/boston.dtb: /cpus/cpu@0: failed to match any schema with compatible: ['img,mips'] >> arch/mips/boot/dts/img/boston.dtb: /system-controller@17ffd000/clock: failed to match any schema with compatible: ['img,boston-clock'] >> /home/flygoat/linux-next/arch/mips/boot/dts/img/boston.dtb: uart@17ffe000: $nodename:0: 'uart@17ffe000' does not match '^serial(@.*)?$' >> from schema $id: http://devicetree.org/schemas/serial/8250.yaml# >> ``` >> >> I think there is no new warning introduced by this patch. >> Did I miss anything here? > > Indeed there might be no warning for this, because syscon allows a lot, > including children. You need custom binding anyway. Hi Krzysztof, I really don't understand the reason behind having a custom binding for such device. It even doesn't have a driver and purely rely on generic syscon regmap to work. I can see devices like mediatek,mt8365-syscfg being described by simple binding have a similar nature, they all describe a register bank and with serval sub nodes to describe devices being instanced under that register block. What makes img,boston-platform-regs special here? Thanks - Jiaxun > > Best regards, > Krzysztof -- - Jiaxun
