Hello, On Fri May 3, 2024 at 6:05 PM CEST, Krzysztof Kozlowski wrote: > On 03/05/2024 17:57, Krzysztof Kozlowski wrote: > > On 03/05/2024 16:20, Théo Lebrun wrote: > >> Switch from sub-nodes in system-controller for each functionality to a > >> single node representing the entire OLB instance. dt-bindings is > >> unnecessary and soc/mobileye/mobileye,eyeq5-olb.yaml will inherit all > >> properties. > > > > Why changing this? You just added these bindings not so long time ago... > > This is very confusing to push bindings and then immediately ask to > > remove them. See this revision as a proposal of something that has been asked multiple times in previous reviews. See message from Stephen Boyd on last revision [0], or discussion with Rob Herring on much earlier revision [1]. Proposal from Stephen Boyd of using auxiliary devices makes sense, that could be the future direction of this series. It won't change the dt-bindings aspect of it, only the driver implementations. [0]: https://lore.kernel.org/lkml/daa732cb31d947c308513b535930c729.sboyd@xxxxxxxxxx/ [1]: https://lore.kernel.org/lkml/20240124151405.GA930997-robh@xxxxxxxxxx/ > One more point - anyway this should be revert with clear explanation WHY > you are reverting bindings. I'll make sure to use standard revert formatting and explain why it is being done. Thanks, -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
