Hi Wolfram, On Sat, Apr 27, 2024 at 10:35:52PM +0200, Wolfram Sang wrote: > There is a confusing pattern in the kernel to use a variable named 'timeout' to there was a little checkpatch warning here for the line being over 75 characters, but I went ahead anyway and pushed the whole series to i2c/i2c-host. Thanks, Andi > store the result of wait_for_*() causing patterns like: > > timeout = wait_for_completion_timeout(...) > if (!timeout) return -ETIMEDOUT; > > with all kinds of permutations. Use 'time_left' as a variable to make the code > self explaining. > > This is the I2C part of a tree-wide series. The rest of the patches can > be found here (slightly WIP): > > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/time_left > > Because these patches are generated, they need manual audit. So, I will > send them step by step. This is part 1 and also a call for opinions if > this is a desirable change. But at least in the I2C realm, I really want > to have it proper. > > Build bot is happy with these patches and I also compile tested them > (except two). No functional changes intended. > > Wolfram Sang (15): > i2c: amd-mp2-plat: use 'time_left' variable with > wait_for_completion_timeout() > i2c: digicolor: use 'time_left' variable with > wait_for_completion_timeout() > i2c: exynos5: use 'time_left' variable with > wait_for_completion_timeout() > i2c: hix5hd2: use 'time_left' variable with > wait_for_completion_timeout() > i2c: imx-lpi2c: use 'time_left' variable with > wait_for_completion_timeout() > i2c: omap: use 'time_left' variable with wait_for_completion_timeout() > i2c: st: use 'time_left' variable with wait_for_completion_timeout() > i2c: stm32f4: use 'time_left' variable with > wait_for_completion_timeout() > i2c: stm32f7: use 'time_left' variable with > wait_for_completion_timeout() > i2c: synquacer: use 'time_left' variable with > wait_for_completion_timeout() > i2c: jz4780: use 'time_left' variable with > wait_for_completion_timeout() > i2c: qcom-geni: use 'time_left' variable with > wait_for_completion_timeout() > i2c: rk3x: use 'time_left' variable with wait_event_timeout() > i2c: s3c2410: use 'time_left' variable with wait_event_timeout() > i2c: pxa: use 'time_left' variable with wait_event_timeout() > > -- > 2.43.0 >
