Re: [PATCH v6 0/2] Add support for Loongson1 DMA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 19, 2024 at 10:40:54AM +0800, Huacai Chen wrote:
> On Tue, Mar 19, 2024 at 10:32 AM Keguang Zhang <keguang.zhang@xxxxxxxxx> wrote:
> >
> > On Mon, Mar 18, 2024 at 11:42 PM Conor Dooley <conor@xxxxxxxxxx> wrote:
> > >
> > > On Mon, Mar 18, 2024 at 10:26:51PM +0800, Huacai Chen wrote:
> > > > Hi, Conor,
> > > >
> > > > On Mon, Mar 18, 2024 at 7:28 PM Conor Dooley <conor@xxxxxxxxxx> wrote:
> > > > >
> > > > > On Mon, Mar 18, 2024 at 03:31:59PM +0800, Huacai Chen wrote:
> > > > > > On Mon, Mar 18, 2024 at 10:08 AM Keguang Zhang <keguang.zhang@xxxxxxxxx> wrote:
> > > > > > >
> > > > > > > Hi Huacai,
> > > > > > >
> > > > > > > > Hi, Keguang,
> > > > > > > >
> > > > > > > > Sorry for the late reply, there is already a ls2x-apb-dma driver, I'm
> > > > > > > > not sure but can they share the same code base? If not, can rename
> > > > > > > > this driver to ls1x-apb-dma for consistency?
> > > > > > >
> > > > > > > There are some differences between ls1x DMA and ls2x DMA, such as
> > > > > > > registers and DMA descriptors.
> > > > > > > I will rename it to ls1x-apb-dma.
> > > > > > OK, please also rename the yaml file to keep consistency.
> > > > >
> > > > > No, the yaml file needs to match the (one of the) compatible strings.
> > > > OK, then I think we can also rename the compatible strings, if possible.
> > >
> > > If there are no other types of dma controller on this device, I do not
> > > see why would we add "apb" into the compatible as there is nothing to
> > > differentiate this controller from.
> >
> > That's true. 1A/1B/1C only have one APB DMA.
> > Should I keep the compatible "ls1b-dma" and "ls1c-dma"?
> The name "apbdma" comes from the user manual, "exchange data between
> memory and apb devices", at present there are two drivers using this
> naming: tegra20-apb-dma.c and ls2x-apb-dma.c.

I think it's unnessesary but I won't stand in your way.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux