[PATCH v2 0/2] MIPS: Fix missing proto and passing arg warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


After getting my local tree rebased onto the kernel 6.8-rc3 the MIPS32
kernel build procedure produced a couple of warnings which I suggest to
fix in the framework of this series.

A first warning is of the "no previous prototype for `<func>`" type. In
particular my arch-specific code has the mips_cm_l2sync_phys_base() method
re-defined, but even though the function is global it' prototype isn't
declared anywhere. Fix that by moving the __mips_cm_l2sync_phys_base()
body to a weak implementation of mips_cm_l2sync_phys_base() and adding the
method prototype declaration to the mips/include/asm/mips-cm.h header
file. For the sake of unification a similar solution was provided for the
mips_cm_phys_base()/__mips_cm_phys_base() couple.

The following text describes the patches which have already merged in at
v1 stage of the patchset (see changelog v2).

One more case of the denoted earlier warning I spotted in the
self-extracting kernel (so called zboot) with the debug printouts enabled.
In particular there are several putc() method re-definitions available in:
All of these files lacked the prototype declaration what caused having the
"no previous prototype for ‘putc’" printed on my build with the next
configs enabled:

The second warning is of the "passing argument <x> of ‘<func>’ from
incompatible pointer type" type which I discovered in the
drivers/tty/mips_ejtag_fdc.c driver. The problem most likely happened due
to the commit ce7cbd9a6c81 ("tty: mips_ejtag_fdc: use u8 for character

That's it for today.) Thanks for review in advance. Any tests are very

Link: https://lore.kernel.org/linux-mips/20240215171740.14550-1-fancer.lancer@xxxxxxxxx
Changelog v2:
- Drop aleady applied pateches:
  [PATCH 3/4] mips: zboot: Fix "no previous prototype" build warning
  [PATCH 4/4] tty: mips_ejtag_fdc: Fix passing incompatible pointer type warning
- Drop Linux serial mailing list and the respective maintainers from the
- Covert the underscored versions of the CM2/L2-sync base address
  getters to being the body of the weakly defined original methods.

Cc: Alexey Malahov <Alexey.Malahov@xxxxxxxxxxxxxxxxxxxx>
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: linux-mips@xxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx

Serge Semin (2):
  mips: cm: Convert __mips_cm_l2sync_phys_base() to weak function
  mips: cm: Convert __mips_cm_phys_base() to weak function

 arch/mips/include/asm/mips-cm.h | 20 ++++++++++++++++----
 arch/mips/kernel/mips-cm.c      | 10 ++--------
 2 files changed, 18 insertions(+), 12 deletions(-)


[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux