Re: [PATCH v1 02/14] serial: core: Add UPIO_UNSET constant for unset port type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 22. 02. 24, 14:21, Andy Shevchenko wrote:
On Thu, Feb 22, 2024 at 07:58:32AM +0100, Jiri Slaby wrote:
On 21. 02. 24, 19:31, Andy Shevchenko wrote:


   	unsigned char		iotype;			/* io access style */
+#define UPIO_UNSET		((unsigned char)~0U)	/* UCHAR_MAX */

Perhaps making the var u8 and this U8_MAX then? It would make more sense to

WFM, should it be a separate change?


Btw, how can I justify it?

Hmm, thinking about it, why is it not an enum?

But it could be also an u8 because you want it be exactly 8 bits as you want to be sure values up to 255 fit.

suse labs

[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux