Re: [PATCH 06/13] i2c: nomadik: use bitops helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Thu, Feb 15, 2024 at 5:52 PM Théo Lebrun <theo.lebrun@xxxxxxxxxxx> wrote:

> Constant register bit fields are declared using hardcoded hex values;
> replace them by calls to BIT() and GENMASK(). Replace custom GEN_MASK()
> macro by the generic FIELD_PREP(). Replace manual bit manipulations by
> the generic FIELD_GET() macro.
> Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>

I'm a fan of this style.
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Linus Walleij

[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux