Re: [PATCH v5 3/3] irqchip/loongson-eiointc: Refine irq affinity setting during resume

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Hi Thomas,

On 2024/2/13 下午5:49, Thomas Gleixner wrote:
On Tue, Jan 30 2024 at 16:27, Bibo Mao wrote:
During suspend and resume, CPUs except CPU0 can be hot-unpluged and IRQs
will be migrated to CPU0. So it is not necessary to restore irq affinity
for eiointc irq controller when system resumes.

That's not the reason. The point is that eiointc_router_init() which is
invoked in the resume path affines all interrupts to CPU0, so the
restore operation is redundant, no?
yes, it is. eiointc_router_init() will enable the irqs and affine all interrupts to CPU0. And it is redundant, the aim of deleted code wants to resume older interrupt affinity when executing "echo mem > /sys/power/state".

This patch removes this piece of code about irq affinity restoring in
function eiointc_resume().

Again. 'This patch' is pointless because we already know that this is a
patch, no?
Thanks for your kindly help, English is somewhat difficult for me :)

Bibo Mao

[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux