Hello, On Fri Feb 16, 2024 at 3:27 AM CET, Rob Herring wrote: > On Thu, Feb 15, 2024 at 05:52:08PM +0100, Théo Lebrun wrote: > > Expose I2C device timeout configuration from devicetree. Use µs as time > > unit and express it in the name. > > > > Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml b/Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml > > index 16024415a4a7..e6b95e3765ac 100644 > > --- a/Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml > > +++ b/Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml > > @@ -70,6 +70,10 @@ properties: > > minimum: 1 > > maximum: 400000 > > > > + timeout-usecs: > > Use standard unit suffixes. > > We already have at least 2 device specific timeout properties. This one > should be common. That means you need to add it to i2c-controller.yaml > in dtschema. GH PR or patch to devicetree-spec list is fine. i2c-mpc (fsl,timeout) and i2c-gpio (i2c-gpio,timeout-ms). I agree this prop has no reason to be compatible-specific. Feedback from dt-bindings and I2C host maintainers would be useful: what should the property be named? Having the unit makes it self-descriptive, which sounds like a good idea to me. timeout-usecs, timeout-us, another option? Thanks, -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
