Hello, On Thu Feb 1, 2024 at 12:00 PM CET, Krzysztof Kozlowski wrote: > On 01/02/2024 11:38, Théo Lebrun wrote: > > Hello, > > > > On Thu Feb 1, 2024 at 9:58 AM CET, Krzysztof Kozlowski wrote: > >> On 31/01/2024 17:26, Théo Lebrun wrote: > >>> Add DT schema bindings for the EyeQ5 clock controller driver. > >>> > >>> Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx> > >>> --- > >> > >> No changelog, tags ignored, I scrolled through first two pages of cover > >> letter and also no changelog. > > > > In this case we fit into the "If a tag was not added on purpose". Sorry > > the changelog was not explicit enough. In my mind it fits into the > > first bullet point of the cover letter changelog: > > > >> - Have the three drivers access MMIO directly rather than through the > >> syscon & regmap. > > ... which I might not even connect to binding patches. I see only one > entry regarding bindings in your changelog, so I find it not much > informative. > > For the future, please state that you ignore tags for given reason. > > > > > That change means important changes to the dt-bindings to adapt to this > > new behavior. In particular we now have reg and reg-names properties > > that got added and made required. > > > > I wanted to have your review on that and did not want to tag the patch > > as already reviewed. > > Makes sense, but how can I know it? Other people often ignore the tags, > so safe assumption is that it happened here as well. I'm prepping a new revision. Should I be taking your previous Reviewed-By tags in? You sent them for the previous revision, do the changes in this V4 look good to you? Thanks Krzysztof, -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
