On 31/01/2024 17:26, Théo Lebrun wrote:
> Add documentation to describe the "Other Logic Block" syscon.
>
> Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>
> ---
> .../bindings/soc/mobileye/mobileye,eyeq5-olb.yaml | 89 ++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 90 insertions(+)
>
...
> +required:
> + - compatible
> + - reg
> + - '#address-cells'
> + - '#size-cells'
> + - ranges
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + system-controller@e00000 {
> + compatible = "mobileye,eyeq5-olb", "syscon", "simple-mfd";
> + reg = <0x0 0xe00000 0x0 0x400>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x0 0xe00000 0x400>;
If there is going to be any resend:
1. ranges follows reg
2. Use lower-case hex
See DTS coding style.
> +
> + clocks: clock-controller@2c {
> + compatible = "mobileye,eyeq5-clk";
> + reg = <0x02C 0x50>, <0x11C 0x04>;
> + reg-names = "plls", "ospi";
> + #clock-cells = <1>;
> + clocks = <&xtal>;
> + clock-names = "ref";
> + };
> +
> + reset: reset-controller@0 {
0 is before 2c, keep nodes properly ordered.
> + compatible = "mobileye,eyeq5-reset";
> + reg = <0x000 0x0C>, <0x200 0x34>, <0x120 0x04>;
> + reg-names = "d0", "d1", "d2";
> + #reset-cells = <2>;
> + };
> +
> + pinctrl: pinctrl@b0 {
> + compatible = "mobileye,eyeq5-pinctrl";
> + reg = <0x0B0 0x30>;
This looks incomplete. Your binding mentions children, so provide at
least one child.
>
Best regards,
Krzysztof
