On Fri, Jan 26, 2024 at 10:24:29PM +0800, Huacai Chen wrote: > On Fri, Jan 26, 2024 at 6:30 PM Thomas Bogendoerfer > <tsbogend@xxxxxxxxxxxxxxxx> wrote: > > > > On Tue, Jan 23, 2024 at 09:47:58AM +0800, Huang Pei wrote: > > [...] > > > diff --git a/arch/mips/loongson64/numa.c b/arch/mips/loongson64/numa.c > > > index 8f61e93c0c5b..6345e096c532 100644 > > > --- a/arch/mips/loongson64/numa.c > > > +++ b/arch/mips/loongson64/numa.c > > > @@ -132,6 +132,8 @@ static void __init node_mem_init(unsigned int node) > > > > > > /* Reserve pfn range 0~node[0]->node_start_pfn */ > > > memblock_reserve(0, PAGE_SIZE * start_pfn); > > > + /* set nid for reserved memory on node 0 */ > > > + memblock_set_node(0, (u64)1 << 44, &memblock.reserved, 1); > > > } > > > } > > > > > > -- > > > 2.30.2 > > > > applied to mips-fixes. > Oh, I'm sorry that I found a very stupid error in this patch. The > comment says set memory on node 0 but the code set it on node 1... and what is correct ? Please send a patch to fix it in mips-fixes. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]