Hello, On Thu Dec 28, 2023 at 8:21 AM CET, Krzysztof Kozlowski wrote: > On 27/12/2023 17:23, Théo Lebrun wrote: > > Add documentation to describe the "Other Logic Block" syscon. > > > > Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx> > > --- > > .../bindings/soc/mobileye/mobileye,eyeq5-olb.yaml | 44 ++++++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 45 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml > > new file mode 100644 > > index 000000000000..b148a49b08f1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml > > @@ -0,0 +1,44 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/mobileye/mobileye,eyeq5-olb.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Mobileye EyeQ5 SoC system controller > > + > > +maintainers: > > + - Grégory Clement <gregory.clement@xxxxxxxxxxx> > > + - Théo Lebrun <theo.lebrun@xxxxxxxxxxx> > > + - Vladimir Kondratiev <vladimir.kondratiev@xxxxxxxxxxxx> > > + > > +description: > > + OLB ("Other Logic Block") is a hardware block grouping smaller blocks. Clocks, > > + resets, pinctrl are being handled from here. > > + > > +properties: > > + compatible: > > + items: > > + - const: mobileye,eyeq5-olb > > + - const: syscon > > + - const: simple-mfd > > + > > + reg: > > + maxItems: 1 > > + > > + reg-io-width: > > + const: 4 > > + > > +required: > > + - compatible > > + - reg > > + - reg-io-width > > It's still wrong order of the patches. Binding should be complete, so > you miss clock-controller in this patch. If you ordered them hoping > there is no dependency between patches, it will not work. You still have > dependency! Your next patch still depends on this, which should be > clearly expressed either in cover letter or next patch. Ah you read me right, I did indeed expect ordering to be enough. I'll squash all changes to mobileye,eyeq5-olb.yaml into a single commit to avoid any dependency. Thanks, -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
